badlion-client 4.5.1 #197991
Open
badlion-client 4.5.1 #197991
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanjkay
reviewed
Jan 12, 2025
Casks/b/badlion-client.rb
Outdated
|
|
||
| url "https://client-updates.badlion.net/Badlion%20Client-#{version}#{arch}.dmg" | ||
| name "Badlion Client" | ||
| desc "Minecraft launcher" | ||
| homepage "https://www.badlion.net/" | ||
|
|
||
| livecheck do | ||
| url "https://client-updates.badlion.net/latest-mac.yml" | ||
| url "https://client-updates.badlion.net/latest.yml" |
There was a problem hiding this comment.
This is the check for the windows version, the in-app updater is still using the old url. So it's an upstream issue, or we could try to use this url instead with the HeaderMatch strategy https://www.badlion.net/download/client/latest/mac
There was a problem hiding this comment.
I have contacted to the upstream through the discord and let them know the .yml file is not updated.
zyoshoka
force-pushed
the
bump-badlion-client-4.5.1
branch
from
df38345 to
83603c0
Compare
p-linnane
added
the
upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.