Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starnet2: make uninstall_preflight fail more gracefully #197424

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Jan 7, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Discovered in #197409

Casks/s/starnet2.rb Outdated Show resolved Hide resolved
@khipp khipp enabled auto-merge January 7, 2025 09:59
@khipp khipp merged commit 2e9f458 into master Jan 7, 2025
10 checks passed
@khipp khipp deleted the starnet2 branch January 7, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants