Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-noto-serif: correct name #196101

Merged
merged 1 commit into from
Dec 22, 2024
Merged

font-noto-serif: correct name #196101

merged 1 commit into from
Dec 22, 2024

Conversation

daviehh
Copy link
Contributor

@daviehh daviehh commented Dec 21, 2024

Name change: This is the serif font, not the noto sans font

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This is the serif font, not the noto sans font
@khipp khipp changed the title Update font-noto-serif: correct name font-noto-serif: correct name Dec 22, 2024
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution to homebrew-cask, @daviehh! 🎉

@khipp khipp merged commit 6db4055 into Homebrew:master Dec 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants