arm-performance-libraries 24.04 (new cask) #170762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvanazamfirei
suggested changes
Apr 6, 2024
There was a problem hiding this comment.
Hi @pthariensflame, is there any reason why the simplified version scheme would not work?
No specific reason, no! It just makes autobump from livecheck harder, but I guess that was out of the question anyways given the install suffix issue. I'll make that change when I can next touch my dev machine! The current system was modeled closely after what's used by |
|
@razvanazamfirei As it turns out, the revision info is not needed for the download URL, so I got rid of it entirely! Thank you for making me look at it more closely! |
|
@razvanazamfirei Any news? |
bevanjkay
reviewed
Apr 12, 2024
bevanjkay
reviewed
Apr 15, 2024
Co-authored-by: Bevan Kay <[email protected]>
bevanjkay
reviewed
Apr 15, 2024
razvanazamfirei
approved these changes
Apr 16, 2024
krehel
approved these changes
Apr 16, 2024
chenrui333
approved these changes
Apr 16, 2024
github-actions bot
pushed a commit
to MPLew-is/homebrew-vscodium
that referenced
this pull request
Apr 17, 2024
…armpl arm-performance-libraries 24.04 (new cask)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.