hma-vpn: rename from hma-pro-vpn

[daeho-ro]

It seems that the pro version is not supported anymore.
https://github.com/Homebrew/homebrew-cask/blob/8166f6d33303cf75a0105c44bc46dce96729987a/Casks/h/hma-pro-vpn.rb

So, I add the generic version of hma-vpn.

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• [v] The submission is for a stable version or documented exception.
• [v] brew audit --cask --online <cask> is error-free.
• [v] brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• [v] Named the cask according to the token reference.
• [v] Checked the cask was not already refused.
• [v] Checked the cask is submitted to the correct repo.
• [v] brew audit --cask --new <cask> worked successfully.
• [v] HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• [v] brew uninstall --cask <cask> worked successfully.

---

[bevanjkay]

Is this the same product, but renamed?

[daeho-ro]

@bevanjkay
I think the pro version is no more maintained and I honestly cannot check that in more details. Anyway, the product is now given by hma-vpn and the package file has different checksum and I decide to register it as a new cask. Also there was a request to check that is going on the pro version from the discussion, see https://github.com/orgs/Homebrew/discussions/5177.

[bevanjkay]

I can see that in 2018 there is reference on the same download page to HMA Pro VPN, so I think it is safe to assume that this is the same app, just with a different name.
https://web.archive.org/web/20180929092636/https://www.hidemyass.com/en-au/download-vpn-mac

[daeho-ro]

Then should I update the existing one not add the new one, right? I am ready, just confirm please.

[krehel]

I would agree with the rename, not new.

[daeho-ro]

@krehel , Is this correct way to rename a package? I am not sure about this.

[krehel]

The goal is to update and rename hma-pro-vpn to hma-vpn? If so, then the changes I've pushed should address that.

[daeho-ro]

That is right. I missed that!

[krehel]

No worries @daeho-ro - happy to help. Thanks for taking the initiative to open this and get it moving forward.