zc 0.14.0 (new cask) #169269
zc 0.14.0 (new cask) #169269
Conversation
BrewTestBot
added
new cask
missing zap
|
It seems that the binary should go to the homebrew core first. |
|
If the binary is built from a closed-source then Aside to this, I am not convinced that the app carries enough notability to be included at this stage. Self-submission (by the vendor) is often an initial sign that there is not demand for the cask to be included in It may be better to begin by offering this in your own tap. |
|
This is indeed built closed-source. We use a wildcard SSL cert https://releases.zectonal.com/ and https://www.zectonal.com/ |
|
Why not use those links in the cask file? |
|
I didn't think of it since this is the first attempt, but I could easily do that...what is the process to handle this PR if I go back and use an HTTPS URL? Should I resubmit a new PR? |
|
You can push additional commits to this PR. We don't currently require commits to be squashed in |
|
Great news...I will update and push the new commits to this PR - thank you for the feedback. |
|
I updated with https that uses our SSL cert |
Casks/z/zc.rb
Outdated
|
|
||
| livecheck do | ||
| url "http://zectonal-releases.s3-website-us-east-1.amazonaws.com/zc/releases/download/index.html" | ||
| url "https://docs.zectonal.com/zc/releases/download/index.html" | ||
| strategy :page_match |
There was a problem hiding this comment.
| strategy :page_match |
The strategy can be removed as page_match is the default.
Casks/z/zc.rb
Outdated
| strategy :page_match | ||
| # regex(%r{href=.*?\"v(\d+(?:\.\d+)*)\/index\.html\"}i) | ||
| regex(%r{href=.*?"http://zectonal-releases\.s3-website-us-east-1\.amazonaws\.com/zc/releases/download/v(\d+(?:\.\d+)*).*}i) | ||
| regex(/href=.*v(\d+(?:\.\d+)*).*/i) |
There was a problem hiding this comment.
| regex(/href=.*v(\d+(?:\.\d+)*).*/i) | |
| regex(%r{href=.*?download/v?(\d+(?:\.\d+)+)/index.html}i) |
There was a problem hiding this comment.
thank you for this feedback. I incorporated into the latest commit below.
|
If no zap is needed for this cask, we should add Regardless, I agree with @bevanjkay that this does not meet our notability requirements. Thank you for the PR, @zectdev and we really appreciate your contribution! Unfortunately, we're going to pass on this for now. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.