writerside 2023.2,232.10165 (new cask) #157813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miccal
reviewed
Oct 17, 2023
Casks/w/writerside.rb
Outdated
Comment on lines
27
to
34
| uninstall_postflight do | ||
| ENV["PATH"].split(File::PATH_SEPARATOR).map { |path| File.join(path, "rover") }.each do |path| | ||
| if File.readable?(path) && | ||
| File.readlines(path).grep(/# see com.intellij.idea.SocketLock for the server side of this interface/).any? | ||
| File.delete(path) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
This is copied from the rustrover Cask, and I assume will need to be updated.
There was a problem hiding this comment.
It turns out that Writerside's command line launcher is named writerside, so I fixed it with that name.
miccal
approved these changes
Oct 18, 2023
|
Thank you @dahlia. |
miccal
approved these changes
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>worked successfully.brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.