Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add caveats #146192

Merged
merged 3 commits into from
May 4, 2023
Merged

docker: add caveats #146192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bbcf3b
Added docker CLI tools install caveat
osalbahr Apr 30, 2023
7b06788
edit caveats
razvanazamfirei May 4, 2023
b549f79
alignment
razvanazamfirei May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Casks/docker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,14 @@
]

caveats <<~EOS
CLI tools are installed after launching Docker. They will be symlinked to one of the following
based on your preference:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your updated caveat. It's more concise and conveys more information.

I just tried to install the cask just to see how it would look like. Is the newline before "based" intended?

Screen Shot 2023-05-04 at 9 39 40 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yes, the line break was intentional as not all terminals line-wrap. I'll change it in the next update so it breaks at 80 char instead of 100.


/usr/local/bin
$HOME/.docker/bin

If your CLI tools were symlinked to $HOME/.docker/bin your path should be modified to include:

$HOME/.docker/bin
$HOME/.docker/bin
EOS
end