Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display-pilot 1.5.0.0_Mac_250102090118 (new cask) #198207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlackty
Copy link
Contributor

@dlackty dlackty commented Jan 14, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@dlackty
Copy link
Contributor Author

dlackty commented Jan 14, 2025

I spent several hours searching for a reliable livecheck source. The app updater uses a signature in the header for authentication, while the webpage relies on a front-end fetch to an API that also validates cookies for authentication.

Given these constraints, I had to omit the livecheck block.

homepage "https://www.benq.com/en-ap/monitor/software/display-pilot-2.html"

livecheck do
skip "No reliable way to get version info"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion! Unfortunately, using page match isn’t feasible because the content on the page is rendered on the front end. Additionally, the API endpoint (https://www.benq.com/api/esupport-tm/getFiles/en_gb/display%20pilot%202/en_gb,ge_ge) requires an Accept-Encoding header and returns 401 otherwise. (Weird design?)

Let me know if there’s an alternative approach you’d recommend!

Copy link
Member

@bevanjkay bevanjkay Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a url provided by the in-app updater that only include the version number - https://qspublic.s3.ap-southeast-1.amazonaws.com/qspublic/qs_app/1001/Display Pilot 2Setup-1.5.0.0-release.dmg

If that link is suitable for the url, we can find the latest version using the spec page for livecheck - https://www.benq.com/en-ap/monitor/software/display-pilot-2/spec.html

We tend not to include software without a reliable livecheck in homebrew-cask, as the maintenance burden is less when the versions can be updated and checked systematically.

Casks/d/display-pilot.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants