-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display-pilot 1.5.0.0_Mac_250102090118 (new cask) #198207
base: master
Are you sure you want to change the base?
Conversation
I spent several hours searching for a reliable livecheck source. The app updater uses a signature in the header for authentication, while the webpage relies on a front-end fetch to an API that also validates cookies for authentication. Given these constraints, I had to omit the livecheck block. |
homepage "https://www.benq.com/en-ap/monitor/software/display-pilot-2.html" | ||
|
||
livecheck do | ||
skip "No reliable way to get version info" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do with page match from
by the download url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion! Unfortunately, using page match isn’t feasible because the content on the page is rendered on the front end. Additionally, the API endpoint (https://www.benq.com/api/esupport-tm/getFiles/en_gb/display%20pilot%202/en_gb,ge_ge) requires an Accept-Encoding
header and returns 401 otherwise. (Weird design?)
Let me know if there’s an alternative approach you’d recommend!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a url provided by the in-app updater that only include the version number - https://qspublic.s3.ap-southeast-1.amazonaws.com/qspublic/qs_app/1001/Display Pilot 2Setup-1.5.0.0-release.dmg
If that link is suitable for the url, we can find the latest version using the spec page for livecheck
- https://www.benq.com/en-ap/monitor/software/display-pilot-2/spec.html
We tend not to include software without a reliable livecheck
in homebrew-cask
, as the maintenance burden is less when the versions can be updated and checked systematically.
599cb8e
to
f11c8cd
Compare
f11c8cd
to
adc2396
Compare
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.