Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: update livecheck #197409

Merged
merged 18 commits into from
Jan 7, 2025
Merged

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Jan 7, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Aligns the regexes to escape the dot in the extension.

daeho-ro
daeho-ro previously approved these changes Jan 7, 2025
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable changes, Thank you @zyoshoka !

@daeho-ro daeho-ro dismissed their stale review January 7, 2025 05:46

Oops, one failed and should check.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Jan 7, 2025
@zyoshoka
Copy link
Contributor Author

zyoshoka commented Jan 7, 2025

CI is failing since it references staged location, which will not exist without installing, with Dir.children during forced uninstall_preflight. I think we can skip CI.

@bevanjkay
Copy link
Member

CI is failing since it references staged location, which will not exist without installing, with Dir.children during forced uninstall_preflight. I think we can skip CI.

This does need to be fixed, because uninstall should succeed when the cask isn't installed, but I'll take a look in a follow-up PR

@bevanjkay bevanjkay added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jan 7, 2025
@bevanjkay bevanjkay enabled auto-merge January 7, 2025 09:03
@bevanjkay bevanjkay merged commit da5a133 into Homebrew:master Jan 7, 2025
47 of 48 checks passed
@zyoshoka zyoshoka deleted the various-update-livecheck branch January 7, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants