Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some brew typecheck homebrew/bundle cases #1554

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/bundle/brew_installer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,18 @@ def install(preinstall: true, no_upgrade: false, verbose: false, force: false)
else
true
end
result = install_result

if installed?
service_change_state!(verbose:) if install_result
link_change_state!(verbose:)
if install_result
service_result = service_change_state!(verbose:)
result &&= service_result
end
link_result = link_change_state!(verbose:)
result &&= link_result
end

install_result
result
end

def install_change_state!(no_upgrade:, verbose:, force:)
Expand Down
Loading