Ignore taps of unavailable formulae #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt
force-pushed
the
ignore-taps-of-unavailable-formulae
branch
from
3ef2ab7 to
c9d792c
Compare
MikeMcQuaid
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue in #1495.
I set up a new machine and ran
brew bundle cleanup --verbosewhich then exited with the following error:This is because I hadn't installed anything and therefore
Formulary.factorycouldn't find the formula.With this change, I'm making an assumption that if we can't find the formula, we don't need to keep its associated tap and therefore it's fine to ignore the exception and consequently not include the tap in
kept_taps.I would like to add a test case butI found spec/stub/exceptions.rb.TapFormulaUnavailableErrorisn't available and wasn't sure it was desired to define it for testing. Let me know if I should.