fix tests if the user has a HOMEBREW_BUNDLE_FILE env var setup #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide a better issue/pull request title and/or description! |
|
@vraravam Thanks for the PR! I'd prefer instead if we fixed the tests that broke in this way. |
vraravam
force-pushed
the
fix-documentation
branch
from
8a0f1e1 to
1d4b156
Compare
vraravam
changed the title
@MikeMcQuaid - fixed the tests as per your review comments. |
vraravam
force-pushed
the
fix-documentation
branch
from
42481dd to
c5d749a
Compare
MikeMcQuaid
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @vraravam!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an env var setup to point to the global
Brewfile. If this is set, and following the contribution guidelines for this repo, then the tests fail. To circumvent that failure, this change in tests is required.