Run tests on Ruby 3.1 #1272
Merged
Run tests on Ruby 3.1 #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Homebrew 4.2.0 runs on Ruby 3.1, let's bump to that. https://brew.sh/2023/12/18/homebrew-4.2.0/
Without this, a test fails because rspec is unable to proxy $CHILD_STATUS/$?. I looked around for another way to handle this but there's no way to unfreeze except through duplication.
```
1) Bundle when the system call fails emits all stdout output even if verbose is false
Failure/Error: success = st.success?
ArgumentError:
Cannot proxy frozen objects, rspec-mocks relies on proxies for method stubbing and expectations.
# ./lib/bundle/bundle.rb:18:in `block in system'
# ./lib/bundle/bundle.rb:12:in `popen'
# ./lib/bundle/bundle.rb:12:in `system'
# ./spec/bundle_utils_spec.rb:22:in `block (4 levels) in <top (required)>'
# ./spec/bundle_utils_spec.rb:22:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:73:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:73:in `block (2 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# FrozenError:
# can't modify frozen object: pid 0 exit 0
# ./lib/bundle/bundle.rb:18:in `block in system'
```
|
I have no idea if what I've done in fe11409 is rational but it solves the test failure resulting from rspec being unable to proxy CHILD_STATUS since it's frozen. |
jacobbednarz
approved these changes
Dec 19, 2023
|
Thanks both! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Homebrew 4.2.0 runs on Ruby 3.1, let's bump to that.
https://brew.sh/2023/12/18/homebrew-4.2.0/