Merge pull request #1021 from chris-araman/mas-account

Remove `mas account` check

lib/bundle/bundle.rb

@@ -30,6 +30,10 @@ def whalebrew_installed?
     end
 
     def mas_signedin?
+      # mas account doesn't work on Monterey (yet)
+      # https://github.com/mas-cli/mas/issues/417#issuecomment-957963271
+      return true if MacOS.version >= :monterey
+
       Kernel.system "mas account &>/dev/null"
     end
 

lib/bundle/mac_app_store_installer.rb

@@ -24,11 +24,6 @@ def preinstall(name, id, no_upgrade: false, verbose: false)
         return false
       end
 
-      if MacOS.version == :monterey
-        puts "Skipping install of #{name} app. mas is not yet functional on Monterey" if verbose
-        return false
-      end
-
       unless Bundle.mas_signedin?
         puts "Not signed in to Mac App Store." if verbose
         raise "Unable to install #{name} app. mas not signed in to Mac App Store."

spec/bundle/mac_app_store_installer_spec.rb

@@ -54,6 +54,7 @@
       it "outputs an error" do
         allow(described_class).to receive(:installed_app_ids).and_return([123])
         allow(described_class).to receive(:outdated_app_ids).and_return([123])
+        allow(MacOS).to receive(:version).and_return(:big_sur)
         expect(Kernel).to receive(:system).with("mas account &>/dev/null").and_return(false)
         expect { described_class.preinstall("foo", 123) }.to raise_error(RuntimeError)
       end
@@ -76,17 +77,6 @@
         end
       end
 
-      context "when on Monterey" do
-        before do
-          allow(MacOS).to receive(:version).and_return(:monterey)
-        end
-
-        it "skips" do
-          expect(Bundle).not_to receive(:system)
-          expect(described_class.preinstall("foo", 123)).to be(false)
-        end
-      end
-
       context "when app is outdated" do
         before do
           allow(described_class).to receive(:installed_app_ids).and_return([123])