Merge pull request #1277 from MikeMcQuaid/fix_nil_usage

Fix some usage of `!foo.nil?`
Homebrew · Jan 9, 2024 · aeb6ac0 · aeb6ac0
2 parents 48adf41 + 63dc8a9
commit aeb6ac0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/bundle/brew_dumper.rb b/lib/bundle/brew_dumper.rb
@@ -25,7 +25,7 @@ def formulae
     end
 
     def formulae_by_full_name(name = nil)
-      return @formulae_by_full_name[name] if !name.nil? && @formulae_by_full_name&.key?(name)
+      return @formulae_by_full_name[name] if name.present? && @formulae_by_full_name&.key?(name)
 
       require "formula"
       require "formulary"

diff --git a/lib/bundle/brew_installer.rb b/lib/bundle/brew_installer.rb
@@ -63,15 +63,15 @@ def install_change_state!(no_upgrade:, verbose:, force:)
     end
 
     def start_service?
-      !@start_service.nil?
+      @start_service.present?
     end
 
     def start_service_needed?
       start_service? && !BrewServices.started?(@full_name)
     end
 
     def restart_service?
-      !@restart_service.nil?
+      @restart_service.present?
     end
 
     def restart_service_needed?
@@ -82,7 +82,7 @@ def restart_service_needed?
     end
 
     def changed?
-      !@changed.nil?
+      @changed.present?
     end
 
     def service_change_state!(verbose:)