Migrate to homebrew-core for Linux #1664
Closed
+49
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Homebrew#566 Update formulae.brew.sh to support Linux formulae from homebrew-core. * Update `_layouts/formula.html` to add separate tables for macOS and Linux dependencies and separate sections for macOS and Linux caveats. * Update `_layouts/formula_json.json` to include OS-specific dependencies and caveats. * Update `index.html` to include Linux in the description. * Update `_config.yml` to use `homebrew-core` as the remote for Linux formulae. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Homebrew/formulae.brew.sh/issues/566?shareId=XXXX-XXXX-XXXX-XXXX).
Setland34
commented
Jan 15, 2025
There was a problem hiding this comment.
Here is an example of a review comment for the _layouts/formula.html file:
The _layouts/formula.html file has a comprehensive structure for displaying formula details. Here are a few suggestions for improvements:
- Code Readability: Consider adding comments for each major section in the HTML to improve readability for future maintainers.
- Conditional Rendering: The conditional checks for
f.disabledandf.deprecatedcould be simplified by using a single condition and combining the CSS classes and titles. - Accessibility: Ensure all links and interactive elements have appropriate ARIA labels for better accessibility.
- Reusability: Some of the repeated code blocks, such as the table rows for
bottleandversions, could be refactored into separate includes to improve reusability and reduce code duplication. - Performance: Minimize the use of inline styles and consider moving them to a separate CSS file for better performance and maintainability.
Overall, the file is well-structured, but these improvements can enhance maintainability and performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566
Update formulae.brew.sh to support Linux formulae from homebrew-core.
_layouts/formula.htmlto add separate tables for macOS and Linux dependencies and separate sections for macOS and Linux caveats._layouts/formula_json.jsonto include OS-specific dependencies and caveats.index.htmlto include Linux in the description._config.ymlto usehomebrew-coreas the remote for Linux formulae.For more details, open the Copilot Workspace session.