Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cask token handling #1145

Merged
merged 1 commit into from
Apr 28, 2024
Merged

update cask token handling #1145

merged 1 commit into from
Apr 28, 2024

Conversation

razvanazamfirei
Copy link
Member

This changes the way we are handling the token. Currently, for casks including @, we see the following:

<tr>
        <td><a href="/cask/brave-browserbeta">brave-browserbeta</a></td>
        <td>1.66.90.0</td>
        <td>Web browser focusing on privacy</td>
        <td>Brave Beta</td>
</tr>

instead of:

<tr>
        <td><a href="/cask/brave-browser@beta">brave-browser@beta</a></td>
        <td>1.66.90.0</td>
        <td>Web browser focusing on privacy</td>
        <td>Brave Beta</td>
</tr>

_includes/cask.html Outdated Show resolved Hide resolved
cask_index.html Show resolved Hide resolved
Co-authored-by: Eric Knibbe <[email protected]>
@razvanazamfirei
Copy link
Member Author

Thanks, @EricFromCanada! I made the changes.

@EricFromCanada
Copy link
Member

Nice work @razvanazamfirei!

@EricFromCanada EricFromCanada merged commit f7c67f5 into Homebrew:master Apr 28, 2024
1 check passed
@razvanazamfirei razvanazamfirei deleted the update-cask-token-handling branch April 29, 2024 01:08
@MikeMcQuaid
Copy link
Member

Thanks @razvanazamfirei and @EricFromCanada for review/merge!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants