Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
usbutils: update portable.patch (usbutils 017)
Signed-off-by: Rui Chen <[email protected]>
- Loading branch information
1 parent
0fe617f
commit 12f3d34
12f3d34There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the authorship, X-Origin, and patch structure was removed here?
12f3d34There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably as it was cherry-pick applied and
git diffwas used instead ofgit format-patch, whereas before it was basically copy-pasted from https://patch-diff.githubusercontent.com/raw/gregkh/usbutils/pull/134.patch.Tbh this really needs upstreaming going forward. If the patch breaks again it may be better to just drop support for it.
12f3d34There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the X-Origin could actually help getting it upstream, since people using it can figure out where it comes from, and maybe contribute. And yes, it would be good to get it upstream. However it would require meson expertise because upstream is switching from autotools to meson.