Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize shared configuration #23

Merged
merged 5 commits into from
May 23, 2024
Merged

Synchronize shared configuration #23

merged 5 commits into from
May 23, 2024

Conversation

BrewTestBot
Copy link
Member

This pull request was created automatically by the sync-shared-config workflow.

@MikeMcQuaid MikeMcQuaid requested a review from a team May 23, 2024 10:40
@Bo98
Copy link
Member

Bo98 commented May 23, 2024

This historically never matched Portable Ruby but I’m OK with this now we are aligning with the latest more often.

This however can cause some desync with the Dockerfile. Do you have any suggestions to how best approach that?

@MikeMcQuaid
Copy link
Member

This however can cause some desync with the Dockerfile. Do you have any suggestions to how best approach that?

Yeh, had solved this in mikemcquaid/strap. Have pushed a commit to handle this consistently everywhere.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid merged commit 70e2e6e into main May 23, 2024
4 checks passed
@MikeMcQuaid MikeMcQuaid deleted the sync-shared-config branch May 23, 2024 15:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants