-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
job: support Intel runners with -x86_64
in runner name
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
carlocab
force-pushed
the
intel-runner-tag
branch
from
May 10, 2024 17:25
b6f61fb
to
47b2145
Compare
Bo98
reviewed
May 10, 2024
carlocab
force-pushed
the
intel-runner-tag
branch
2 times, most recently
from
May 11, 2024 17:40
2fd99e8
to
4686f76
Compare
We currently download unneeded artifacts in CI runs because the glob for, say, `bottles_14*` matches artifacts built on both Intel and M1 runners. Adding the architecture to the runner name will allow us to use a more specific glob which prevents needlessly downloading artifacts that we won't use.
Co-authored-by: Bo Anderson <[email protected]>
carlocab
force-pushed
the
intel-runner-tag
branch
from
May 11, 2024 17:43
cd7c871
to
74af280
Compare
Bo98
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
carlocab
added a commit
to Homebrew/actions
that referenced
this pull request
May 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently download unneeded artifacts in CI runs because the glob
for, say,
bottles_14*
matches artifacts built on both Intel and M1runners.
Adding the architecture to the runner name will allow us to use a more
specific glob which prevents needlessly downloading artifacts that we
won't use.