Run advisory concat through Bundler - #41
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煝 Ready to approve
The workflow updates match the stated goal and the regression spec covers both workflows, with only a minor test-diagnostics improvement suggested.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates the ingest and regenerate GitHub Actions workflows to run advisories:concat via Bundler so the Rake environment can load gems from vendor/bundle, and adds an RSpec regression test to enforce this.
Changes:
- Switch
advisories:concatworkflow step fromrake ...tobundle exec rake ...in both ingest and regenerate workflows. - Add a spec that parses both workflow YAML files and asserts the concat step runs via Bundler.
File summaries
| File | Description |
|---|---|
spec/workflows_spec.rb |
Adds a regression spec validating the concat step command in both workflows. |
.github/workflows/regenerate.yml |
Runs advisories:concat via bundle exec in the regenerate workflow. |
.github/workflows/ingest.yml |
Runs advisories:concat via bundle exec in the ingest workflow. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 馃憤 or 馃憥 to tell us if it's correct.
p-linnane
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
advisories:concatthrough Bundler in the regenerate and ingest workflows so the Rakefile can load RSpec fromvendor/bundle.Add a regression spec covering both workflow commands.