Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass along skipConditions when filtering out infinitelyNarrowPatches #117

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

hf-kklein
Copy link
Contributor

No description provided.

@hf-kklein hf-kklein requested a review from Copilot March 10, 2025 07:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR addresses a bug by ensuring that skipConditions are passed along when filtering out infinitely narrow patches in the patch chain.

  • Updates the constructor call for TimeRangePatchChain to include skipConditions
  • Ensures consistency in patch processing when skip conditions apply

Reviewed Changes

File Description
ChronoJsonDiffPatch/ChronoJsonDiffPatch/TimeRangePatchChain.cs Passes _skipConditions to the TimeRangePatchChain constructor when filtering out infinitely narrow patches

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

ChronoJsonDiffPatch/ChronoJsonDiffPatch/TimeRangePatchChain.cs:327

  • Ensure that passing _skipConditions into the TimeRangePatchChain constructor does not inadvertently alter the behavior of patch filtering. Verify that _skipConditions is properly initialized and tested in this context to maintain consistent patch application.
GetAll().Where(p => !p.Equals(patchToBeAdded)),

@hf-kklein hf-kklein merged commit 7a51a24 into main Mar 10, 2025
7 checks passed
@hf-kklein hf-kklein deleted the skipconditions branch March 10, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant