🧹 Cleanup Tests + Fixtures #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
commented
Jul 18, 2024
Comment on lines
+10
to
+14
| # sys.path.insert( | ||
| # 0, str(Path(__file__).resolve().parents[1] / "src") | ||
| # ) # it is needed just one time to be able to import the module | ||
| # You don't need this. Follow the instructions from the python-template repository. | ||
| # You have to mark the src directory as a source root (blue) in PyCharm + the unittests directory as a test root (green) |
hamidhajiparvaneh
added a commit
that referenced
this pull request
Jul 18, 2024
* adding generating using quicktype * black and isort * 🔥 Remove unnecessary test file * linting * adding test-data (schema + expected output) * adding duplicate tesst (test is still red) * 🛠️ Fix enum file path in process_directory function * return it to enum * ✨ Remove unnecessary enumConverter definitions * 🛠️ Remove unnecessary code snippets - Removed specific classes from files - Added TODOs for unresolved issues * black * type_check * linting * adding nodejs and quicktype npm * linting * adding npm in coverage * remove changedir = unittests from coverage * Update unittests/test_generator.py Co-authored-by: konstantin <[email protected]> * Update unittests/test_tooling.py Co-authored-by: konstantin <[email protected]> * clean up * linting and type_check * ✨ Refactor Quicktype executable path determination logic Simplified the logic for determining the Quicktype executable path. * linting * 🧹 Cleanup Tests + Fixtures (#24) * 🧹 Cleanup Tests + Fixtures remove pylint disable * further fixes * fix mypy * adding quicktype path finder --------- Co-authored-by: konstantin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove pylint disable