Layer 2: add command parity harness#2878
Conversation
There was a problem hiding this comment.
aboimpinto has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Thanks @aboimpinto for taking the time to contribute. This repository is currently observing a maintainer-managed contribution gate in dry-run mode, so this pull request is staying open. When enforcement is enabled, pull requests from contributors who are not listed in Please read |
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive unit tests to validate command registry metadata, alias resolution, help topics, argument parsing, and command palette entries. The feedback suggests optimizing test performance by reusing a single App instance across iterations in the help topic test, and simplifying loop variables by pattern matching &alias to avoid double references when iterating over command aliases.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
aboimpinto has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
aboimpinto has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Summary
Context
This is Layer 2 of the command refactor breakdown. PR #2851 remains the reference branch, but this PR keeps the mergeable slice test-only so the later group-owned command-file refactor can prove behavior parity before production code moves.
Refs #2791
Refs #2870
Reference #2851
Follows #2871
Validation
cargo fmtcargo test -p codewhale-tui commands::tests::cargo test -p codewhale-tui command_palettecargo test -p codewhale-tui slash_completioncargo test -p codewhale-tuiPaulo Aboim Pinto