Skip to content

Layer 2: add command parity harness#2878

Merged
Hmbown merged 2 commits into
Hmbown:codex/v0.9.0-stewardshipfrom
aboimpinto:feat/2791-command-parity-harness-layer2
Jun 7, 2026
Merged

Layer 2: add command parity harness#2878
Hmbown merged 2 commits into
Hmbown:codex/v0.9.0-stewardshipfrom
aboimpinto:feat/2791-command-parity-harness-layer2

Conversation

@aboimpinto

Copy link
Copy Markdown
Contributor

Summary

  • Add a command registry parity harness for metadata completeness, name/alias lookup, and per-command help topic coverage.
  • Pin slash parser argument preservation for representative model-instruction commands.
  • Add representative dispatch-surface checks across the future command groups before moving implementations.
  • Add command palette parity coverage so every registered command appears exactly once with the expected palette insertion text and help/usage description.

Context

This is Layer 2 of the command refactor breakdown. PR #2851 remains the reference branch, but this PR keeps the mergeable slice test-only so the later group-owned command-file refactor can prove behavior parity before production code moves.

Refs #2791
Refs #2870
Reference #2851
Follows #2871

Validation

  • cargo fmt
  • cargo test -p codewhale-tui commands::tests::
  • cargo test -p codewhale-tui command_palette
  • cargo test -p codewhale-tui slash_completion
  • cargo test -p codewhale-tui

Paulo Aboim Pinto

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aboimpinto has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Thanks @aboimpinto for taking the time to contribute.

This repository is currently observing a maintainer-managed contribution gate in dry-run mode, so this pull request is staying open. When enforcement is enabled, pull requests from contributors who are not listed in .github/APPROVED_CONTRIBUTORS will be closed automatically.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant PR access by commenting /lgtm on a pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive unit tests to validate command registry metadata, alias resolution, help topics, argument parsing, and command palette entries. The feedback suggests optimizing test performance by reusing a single App instance across iterations in the help topic test, and simplifying loop variables by pattern matching &alias to avoid double references when iterating over command aliases.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crates/tui/src/commands/mod.rs Outdated
Comment thread crates/tui/src/commands/mod.rs Outdated
Comment thread crates/tui/src/commands/mod.rs Outdated

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aboimpinto has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@aboimpinto aboimpinto marked this pull request as ready for review June 7, 2026 14:31

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aboimpinto has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@Hmbown Hmbown merged commit b0d9c31 into Hmbown:codex/v0.9.0-stewardship Jun 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants