Refactor TUI command groups into focused implementations#2851

Draft

aboimpinto wants to merge 101 commits into

Hmbown:mainfrom

aboimpinto:feat/command-strategy

Commits on Jun 3, 2026

Phase 3: pausable command lifecycle (pause/resume/cancel)
aboimpinto
committed
fix: correct UiTheme field names in sidebar pause indicator
aboimpinto
committed
fix: keep pausable flag across TurnStarted, handle cancel-while-paused, clear on turn end
aboimpinto
committed
fix: use shared Arc<StdMutex<bool>> for paused flag (bypasses Op channel, works during active turns)
aboimpinto
committed
fix: keep paused/paused_cancelled visible after turn ends, show 'Pausing...' initially
aboimpinto
committed
debug: add tracing::debug! at pause key points (set_paused, pause gate, PauseCommand)
aboimpinto
committed
fix: show (Pausing) in WorkBench during transition, let 'continue' message flow through as normal user message
aboimpinto
committed
fix: any message while paused unpauses and sends, instead of blocking non-'continue' messages
aboimpinto
committed
fix: cancel old turn when unpausing with a new message to prevent command leaking
aboimpinto
committed
fix: when paused and user types, cancel old turn; consume message so the user retypes fresh
aboimpinto
committed
fix: pause gate cancels turn instead of returning tool error (prevents model from trying alternatives)
aboimpinto
committed
fix: mark hunt as Hunted on successful turn completion (green checkmark in WorkBench)
aboimpinto
committed
feat: play icon ▶ while running (yellow), green checkmark ✓ on completion (green)
aboimpinto
committed
fix: cancel-while-paused now also calls engine_handle.cancel() — actually stops the turn
aboimpinto
committed
fix: merge pause indicator into the goal line (replaces icon instead of separate line)
aboimpinto
committed
fix: 'continue'/'resume' unpauses and lets message through (one keystroke); other messages cancel + consume
aboimpinto
committed
fix: clear todos and plan state when a new slash command starts (no stale 100% from previous command)
aboimpinto
committed
fix: second ESC while paused returns CancelRequest even after turn ended (pausable/paused flags extend the cancel window)
aboimpinto
committed
fix: cancel-while-paused clears flag directly (not via set_paused) to prevent 'Command resumed' event overriding cancel status
aboimpinto
committed
fix: new slash command clears pause state (app + engine flag); safety sync in dispatch_user_message; direct flag clear in cancel path
aboimpinto
committed
fix: safety sync clears engine flag when app.paused is false, even if app.pausable is true (new pausable command after cancel)
aboimpinto
committed
test: add 8 pause lifecycle tests (indicator states, goal icons) + fix mock engine handle missing shared_paused
aboimpinto
committed
fix: standardised status messages — Request is Pausing / Request was Paused / Request was Resumed / Request was Cancelled
aboimpinto
committed
fix: remove redundant Op::SetPaused try_send from set_paused() — avoids race where late engine status overwrites cancel/resume; add guard in Event::Status handler; update test to verify guard
aboimpinto
committed
test: verify new slash command after cancel clears all pause state
aboimpinto
committed
fix: remove unused Op::SetPaused variant and handler (dead code warning)
aboimpinto
committed
fix: clear hunt.quarry on cancel so model doesn't resume old command in next turn; add test
aboimpinto
committed
fix: clear hunt.quarry on successful completion so model stops being prompted to continue the goal
aboimpinto
committed
feat: pause now lets messages through (no cancel); quarry saved/restored for resume
aboimpinto
committed
fix: set pause message as quarry so model knows command is on hold instead of continuing
aboimpinto
committed
test: add pause_sets_pause_message_as_quarry; strengthen pause instruction to tell model NOT to continue
aboimpinto
committed
fix: clear hunt.quarry on pause so goal system doesn't prompt model to continue; quarry restored on resume
aboimpinto
committed
test: add lifecycle workflow tests (pause->continue->complete, pause->cancel->new command)
aboimpinto
committed
fix: keep quarry on cancel so WorkBench shows ✘ with the original goal; restore from paused_quarry on cancel; clear quarry in dispatch_user_message when next message is sent
aboimpinto
committed
fix: display paused_quarry in WorkBench when hunt.quarry is None during pause (sidebar stays visible)
aboimpinto
committed
fix: non-continue message while paused cancels old turn + clears hunt state; continue/restore only on explicit 'continue'
aboimpinto
committed
fix: detect 'continue the scan' / 'resume the paused command' as resume; keep paused_quarry for later resume; show paused_quarry only when paused/cancelled
aboimpinto
committed
fix: keep pause indicator visible while paused_quarry exists, even after unpausing with a non-continue message (user can still see what's on hold)
aboimpinto
committed
test: non_continue_while_paused_clears_system_prompt_goal — proves hunt.quarry is None for system prompt, paused_quarry preserved for WorkBench
aboimpinto
committed
test: workbench_visible_through_pause_ask_resume — proves WorkBench persists start->pause->how-are-you->resume (no step loses the goal display)
aboimpinto
committed
fix: inject cancellation notice into message when non-continue sent while paused — tells model not to continue old command
aboimpinto
committed
test: resume_switches_icon_from_pause_to_play — verifies icon changes from ⏸ to ▶ after resume
aboimpinto
committed
debug: add tracing::debug! for pause state in sidebar_work_summary
aboimpinto
committed
fix: intercept resume in submit_or_steer_message (catches Steer path that bypasses dispatch_user_message); keep quarry on completion (sidebar shows ✓)
aboimpinto
committed
chore: remove unused mut on message in submit_or_steer_message
aboimpinto
committed
debug: add tracing at submit_or_steer interception point
aboimpinto
committed
fix: add resume interception in steer_user_message (belt-and-suspenders)
aboimpinto
committed
fix: detect 'please continue' / 'resume the command' at any word position; test catches exact scenario from log
aboimpinto
committed
cleanup: remove debug eprintln traces
aboimpinto
committed

Commits on Jun 4, 2026

Commits on Jun 5, 2026

Commits on Jun 6, 2026