Refactor: 마커 업데이트 로직 리팩토링 #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tilt 상태로 마커 이동시 tilt 정보도 이전 마커 포지션에 저장되는 버그 발견, tilt된 상태를 마커에 반영은 하되, 포지션에는 반영하지 않도록 수정
- 맵에 소스를 적용하는 과정의 단계를 나누어서 처리하게 설계했습니다 -> useFilterling (필터링 관련 데이터 처리 ) -> useMapSourceAndLayer (받은 데이터 맵에 적용) -> ... 소스 처리 과정에있어서 레이어를 나누었습니다
Sangjun-man
requested review from
sjsjsj1246,
hyorish03 and
yeoularu
as code owners
✅ Deploy Preview for hipspot ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
이거 다음 스프린트 전까지 내용 작성해서 머지 하겠슴다~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작성예정
https://docs.mapbox.com/help/troubleshooting/mapbox-gl-js-performance/