Fixes based on review comments on previous PR

HifiExperiments · Oct 19, 2024 · d7c743b · d7c743b
1 parent 96e864e
commit d7c743b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/libraries/entities/src/ZoneEntityItem.h.in b/libraries/entities/src/ZoneEntityItem.h.in
@@ -57,6 +57,14 @@ public:
     const TonemappingPropertyGroup& getTonemappingProperties() const { return _tonemappingProperties; }
     const AmbientOcclusionPropertyGroup& getAmbientOcclusionProperties() const { return _ambientOcclusionProperties; }
 
+    /**
+     * @brief Backwards compatibility for screenshare and the like
+     * Doesn't do anything.
+     * @param value
+     */
+    void ignoreUint32(uint32_t value) { /* nothing */ };
+
+
     void setUserData(const QString& value) override;
 
     bool keyLightPropertiesChanged() const { return _keyLightPropertiesChanged; }

diff --git a/libraries/networking/src/udt/PacketHeaders.h b/libraries/networking/src/udt/PacketHeaders.h
@@ -341,8 +341,8 @@ enum class EntityVersion : PacketVersion {
     ShadowBiasAndDistance,
     TextEntityFonts,
     ScriptServerKinematicMotion,
-    // TODO: This was "ScreenshareZone". Drop it on the next protocol change.
-    DropOnProtocolChange,
+    // This was ScreenshareZone, property was dropped.
+    ScreenshareZoneUnused,
     ZoneOcclusion,
     ModelBlendshapes,
     TransparentWeb,