Update 1st classes #2726

haurenburu · 2020-05-17T02:56:11Z

Pull Request Prelude

I have followed proper Hercules code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

1. Swordsman
1.1 Magnum Break

Reduces delay after skill from 2 seconds to 0.5 seconds.
Adds 2 seconds cooldown.

2. Merchant
2.1 Crazy Uproar

Adds 0.5 seconds fixed casting time.
Adds 1 second variable casting time.
Changes skill mechanism, grants Str + 4 and Atk + 30 to the user and nearby party members.
Adds 30 seconds cooldown.

3. Mage
3.1 Fire Bolt/ Cold Bolt/ Lightning Bolt

Increases fixed casting time from 0.88 seconds to 1.2 seconds (on level 10).
Reduces variable casting time from 3.52 seconds to 3.2 seconds (on level 10).
Greatly reduces delay after skill.

3.2 Thunderstorm

Reduces fixed casting time from 1.6 seconds to 1.5 seconds (on level 10).
Reduces variable casting time from 6.4 seconds to 4.5 seconds (on level 10).

3.3 Fire Ball

Fixed casting time and variable casting time of level 1-5 is changed to be the same as level 6-10 (0.2/0.8 seconds respectively)
Reduces delay after skill to 0.7 seconds on every skill level.

3.4 Soul Strike

Delay after skill is 1.4 seconds on every skill level (reduces from 2.5 seconds to 1.4 seconds on level 10).

3.5 Frost Diver

Reduces delay after skill from 1.5 seconds to 0.5 seconds.

4. Acolyte
4.1 Blessing

Also increases Hit by 2 per skill level (Also applies on Archbishop's Clementia too).

4.2 Increases Agility

Also increases attack speed (reduces delay after attack by 1%) per skill level (Also applies on Archbishop's Cantocandidus too)

4.3 Angelus

Also increases MaxHP by 50 per skill level.

4.4 Holy Light

Reduces fixed casting time and variable casting time by 50%.

Issues addressed: #2725

tlacson7 · 2020-05-25T12:41:12Z

U mean pre-re will also take this? I hope not.

Kenpachi2k13 · 2020-05-27T18:26:21Z

Change some skills behaviors to match kro

Could you please change this to a list of changes contained in this PR? This would simplify the review a lot.

haurenburu · 2020-06-06T19:36:12Z

@Kenpachi2k13 sorry for the delay to edit :D

@tlacson7 no, all changes comes only to renewal

ghost · 2020-09-15T20:06:23Z

src/map/status.c

@@ -248,7 +248,7 @@ static void initChangeTables(void)
 	status->set_sc( SM_AUTOBERSERK       , SC_AUTOBERSERK  , SCB_NONE );
 	add_sc( TF_SPRINKLESAND      , SC_BLIND           );
 	add_sc( TF_THROWSTONE        , SC_STUN            );
-	status->set_sc( MC_LOUD              , SC_SHOUT        , SCB_STR );
+	status->set_sc( MC_LOUD              , SC_SHOUT        , SCB_STR ); // i made a mistake here, aparently SCB_WATAK don`t need to be pass


this comment is confusing, I didn't get it

i THINK on my first implementation i set SCB_STR|SBC_WATK but realize that isn't needed for the atk bonus

After I applied the diff I got an error where the +ATK wouldn't count unless I unequiped and equiped the weapon. Therefore I thinks is better to set the SCB_* here.
I also have changed the SCB_WATK to SCB_BATK and now its working fine. So the new line should be:

status->set_sc( MC_LOUD , SC_SHOUT , SCB_STR | SCB_BATK );

ghost · 2020-09-15T20:07:00Z

src/map/status.c

+	//TODO: test the aspd inc
+#ifdef RENEWAL
+	if (sc->data[SC_INC_AGI])
+			aspd_rate += sc->data[SC_INC_AGI]->val1 * 10;


remove a TAB here so it stay with the same indentation as the rest of the code

ADM-Nax · 2021-01-18T18:25:10Z

src/map/status.c

@@ -248,7 +248,7 @@ static void initChangeTables(void)
 	status->set_sc( SM_AUTOBERSERK       , SC_AUTOBERSERK  , SCB_NONE );
 	add_sc( TF_SPRINKLESAND      , SC_BLIND           );
 	add_sc( TF_THROWSTONE        , SC_STUN            );
-	status->set_sc( MC_LOUD              , SC_SHOUT        , SCB_STR );
+	status->set_sc( MC_LOUD              , SC_SHOUT        , SCB_STR ); // i made a mistake here, aparently SCB_WATAK don`t need to be pass


After I applied the diff I got an error where the +ATK wouldn't count unless I unequiped and equiped the weapon. Therefore I thinks is better to set the SCB_* here.
I also have changed the SCB_WATK to SCB_BATK and now its working fine. So the new line should be:

status->set_sc( MC_LOUD , SC_SHOUT , SCB_STR | SCB_BATK );

ADM-Nax · 2021-01-18T18:29:21Z

src/map/status.c

-
+#ifdef RENEWAL
+	if (sc->data[SC_SHOUT])
+		watk += sc->data[SC_SHOUT]->val2;


I have changed this watk to batk for a better use:

if (sc->data[SC_SHOUT]) batk += sc->data[SC_SHOUT]->val2;

But this should be added under the batk section, therefore after (line 5065 in my case - may differ):

if (sc->data[SC_SHRIMP]) batk += batk * sc->data[SC_SHRIMP]->val2 / 100;

ADM-Nax · 2021-01-18T19:49:19Z

src/map/status.c

@@ -199,11 +199,11 @@ static void initChangeTables(void)
 	add_sc( MG_STONECURSE        , SC_STONE           );
 	add_sc( AL_RUWACH            , SC_RUWACH          );
 	add_sc( AL_PNEUMA            , SC_PNEUMA          );
-	status->set_sc( AL_INCAGI            , SC_INC_AGI         , SCB_AGI|SCB_SPEED );
+	status->set_sc( AL_INCAGI            , SC_INC_AGI         , SCB_AGI|SCB_SPEED);


missing SCB_ASPD:
status->set_sc( AL_INCAGI , SC_INC_AGI , SCB_AGI|SCB_SPEED|SCB_ASPD );

ADM-Nax · 2021-01-18T20:23:48Z

src/map/status.c

+#ifdef RENEWAL
+	if (sc->data[SC_INC_AGI])
+		aspd_rate += sc->data[SC_INC_AGI]->val1 * 10;
+#endif


The formula is not working properly.
I Have changed to (under the aspd bonus in the bottom of the section **// ASPD percentage values**):

if (sc->data[SC_INCREASEAGI]) bonus += sc->data[SC_INC_AGI]->val1;

MishimaHaruna · 2024-03-30T19:48:24Z

Superseded by #3218 (currently available in the rebalance branch for preliminary testing)

haurenburu added 5 commits May 16, 2020 20:17

knight

4cdade6

Merchant

ce5548f

Acolyte (need to confirm if agi is increasing aspd)

4413a10

Mage

d841ef8

revert packetver to 20190530

ea8e0df

dastgirp changed the base branch from stable to master May 17, 2020 07:30

haurenburu added 3 commits May 17, 2020 19:27

fixed #ifdef status.c

653f5d5

fix #ifdef skill.c

09e0211

SCB_WATAK remove in SC_SHOUT

26a660d

haurenburu mentioned this pull request May 22, 2020

1st classes's skills update #2725

Closed

4 tasks

ghost suggested changes Sep 15, 2020

View reviewed changes

remove an extra tab on line 6126

5d5fed1

ADM-Nax reviewed Jan 18, 2021

View reviewed changes

MishimaHaruna closed this Mar 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update 1st classes #2726

Update 1st classes #2726

haurenburu commented May 17, 2020 •

edited

Loading

tlacson7 commented May 25, 2020

Kenpachi2k13 commented May 27, 2020

haurenburu commented Jun 6, 2020

ghost Sep 15, 2020

haurenburu Sep 17, 2020

ADM-Nax Jan 18, 2021

ghost Sep 15, 2020

ADM-Nax Jan 18, 2021

ADM-Nax Jan 18, 2021

ADM-Nax Jan 18, 2021

ADM-Nax Jan 18, 2021 •

edited

Loading

MishimaHaruna commented Mar 30, 2024

Update 1st classes #2726

Update 1st classes #2726

Conversation

haurenburu commented May 17, 2020 • edited Loading

Pull Request Prelude

Changes Proposed

tlacson7 commented May 25, 2020

Kenpachi2k13 commented May 27, 2020

haurenburu commented Jun 6, 2020

ghost Sep 15, 2020

Choose a reason for hiding this comment

haurenburu Sep 17, 2020

Choose a reason for hiding this comment

ADM-Nax Jan 18, 2021

Choose a reason for hiding this comment

ghost Sep 15, 2020

Choose a reason for hiding this comment

ADM-Nax Jan 18, 2021

Choose a reason for hiding this comment

ADM-Nax Jan 18, 2021

Choose a reason for hiding this comment

ADM-Nax Jan 18, 2021

Choose a reason for hiding this comment

ADM-Nax Jan 18, 2021 • edited Loading

Choose a reason for hiding this comment

MishimaHaruna commented Mar 30, 2024

haurenburu commented May 17, 2020 •

edited

Loading

ADM-Nax Jan 18, 2021 •

edited

Loading