Display unpinned clipboard items on top

[eranl]

Does this change need to be optional?

Fixes #1902, fixes #1976.

[Helium314]

Yes, this should definitely be optional as I expect it may break flow many people are used to.

[eranl]

Added setting.

Also:

• moved ClipboardHistoryView.clipboardHistoryManager initialization up before initialize() call, and made it lateinit, as it is now (almost) always set before use, and it's essential for functionality. But I can revert if preferred.
• moved initial sorting to initialize(), after settings are loaded.
• when this setting is changed, settings will be reloaded twice, in order to make sure they are reloaded before sorting. The alternative is a delay, as in

  HeliBoard/app/src/main/java/helium314/keyboard/latin/utils/ToolbarUtils.kt

  Lines 43 to 44 in 9bc7da7

  	GlobalScope.launch {
  	delay(10) // need to wait until SettingsValues are reloaded

  .

[Helium314]

• moved ClipboardHistoryView.clipboardHistoryManager initialization up before initialize() call, and made it lateinit, as it is now (almost) always set before use, and it's essential for functionality. But I can revert if preferred.

Definitely fine and makes sense. Not sure why it was actually nullable, while other variable were lateinit from the start (1cbbf49).

• when this setting is changed, settings will be reloaded twice, in order to make sure they are reloaded before sorting. The alternative is a delay, as in

  HeliBoard/app/src/main/java/helium314/keyboard/latin/utils/ToolbarUtils.kt

  Lines 43 to 44 in 9bc7da7

  	GlobalScope.launch {
  	delay(10) // need to wait until SettingsValues are reloaded

This is only triggered when changing the setting in the settings screen, so being inefficient and reloading twice is not an issue.
Tough I would like to avoid having logic in there that's about settings that only change in a settings screen. You could just call KeyboardSwitcher.reloadKeyboard on switch change I think. If you want to keep it, at least add a comment why it's there.

[Helium314]

Did you have some issues where SettingsValues were not yet loaded when the list is being sorted?

[eranl]

Yes, before I removed this line. But then I decided to keep this safe call just in case.

[Helium314]

Thanks! Reproduced and fixed by loading settings before calling ClipboardHistoryManager.onCreate

[eranl]

You could just call KeyboardSwitcher.reloadKeyboard on switch change I think.

That doesn't work, because the onSharedPreferenceChanged call order is still random. It also causes a switch to the abc keyboard if you're on clipboard history.

add a comment why it's there.

I have.

[eranl]

Reordered comparison logic, to make it slightly more efficient, and maybe a bit clearer.

[Helium314]

It also causes a switch to the abc keyboard if you're on clipboard history.

I think that doesn't matter, but the onSharedPreferenceChanged definitely does.