Add setting for controlling if emojis are included in suggestions #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Add `Dictionary.TYPE_EMOJI` constant.
Helium314
reviewed
Jun 28, 2025
app/src/main/java/helium314/keyboard/settings/screens/TextCorrectionScreen.kt
Outdated
Show resolved
Hide resolved
Helium314
reviewed
Jun 28, 2025
| useContactsDict: Boolean, | ||
| useAppsDict: Boolean, | ||
| usePersonalizedDicts: Boolean, | ||
| useEmojiDict: Boolean, |
Owner
There was a problem hiding this comment.
I'd prefer reading the setting as part of resetDictionaries, instead of putting useEmojiDict in the interface.
Contributor
Author
There was a problem hiding this comment.
I followed the pattern of passing the other settings. Why should it be done differently?
Owner
There was a problem hiding this comment.
The other settings are checked in usesSameSettings to check whether a reload is necessary. This is not done with useEmojiDict, here a completely different way of reloading is used (resetDictionaryFacilitatorIfNecessary).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a
Dictionary.TYPE_EMOJIconstant.See discussion.