Always show popup hint only if key has popups and no hint label

[eranl]

Also, only show popup hint on space bar if mSpaceForLangChange is on.

The idea here is to simplify the setting of the popup hint, and to make it more consistent. Currently, some keys have both a hint label and a popup hint, and some keys with popups have neither.

I wasn't able to figure out what was the issue with the appearance of the Armenian period key in holo theme that was fixed by the code I removed.

Fixes #1691.

[Helium314]

Not sure about this, users might have the label flag in custom layouts for some completely different purpose.
Depending on feedback I might revert the change.

has popup hint should also be removed from attrs.xml then, and potentially from built-in layouts if any use the code.

[BlackyHawky]

I'm allowing myself to intervene here but I'm afraid that this change will once again break an existing functionality or display that is not requested by any user... ...

[eranl]

@BlackyHawky, thank you for the feedback. I was actually hoping you'd intervene. 🙂
Why do you consider this as breaking rather than fixing? IMO as a user, the current inconsistency is a bug.

[BlackyHawky]

@eranl

Why do you consider this as breaking rather than fixing?

Currently, I don't know because I haven't tested your PR (that's why I wrote "I'm afraid").

I only hope that custom layouts are not affected by this change.

[eranl]

I'm curious: do you use hasPopupHint in your layouts?

[eranl]

users might have the label flag in custom layouts for some completely different purpose.

Should I continue to support this for custom layouts only?

[Helium314]

Currently it's shown on comma, language switch key, space, action key. And on numpad on +, -, *, comma, $, space
With this PR it's shown on shift, comma, language switch key, space, period, action key. And on all keys with popups in symbols / more symbols. And on numpad on comma and space.

I guess what will almost definietly be disliked is the … on many keys in symbols layouts. On one hand it does help with discoverability of popups, on the other hand it looks so weird that I wouldn't want it.

Not sure if popups would be what users expect when the enable a setting to Show hints if long-pressing a key triggers additional functionality. One could argue both ways.

[eranl]

Not sure if popups would be what users expect when the enable a setting to Show hints if long-pressing a key triggers additional functionality. One could argue both ways.

I was going to suggest a rewording of the two very confusing popup hint settings next. 🙂 I actually only completely figured them out yesterday.

[eranl]

I guess what will almost definietly be disliked is the … on many keys in symbols layouts. On one hand it does help with discoverability of popups, on the other hand it looks so weird that I wouldn't want it.

I would argue: what's the point in having popups if users don't have a clue they're there? Are they expected to try every key just to check if it has any?

[Helium314]

My point of view is quite different: will users complain because the keyboard suddenly looks different. I considered adding popup hints to symbols layouts quite a while ago, and that also was not wanted because then things look different.

And I guess users would rather have popup hints on symbols layouts than the functional hints.

[eranl]

So it's the usual tradeoff between making the app more friendly to new users vs. not making changes that will frustrate old ones.
We could address it with yet another setting, and even make the default value different for new installs vs. upgrades, but that seems like overkill to me.

Would it be more acceptable if I limited this change to functional keys? I think that's where the most benefit lies.

[Helium314]

Would it be more acceptable if I limited this change to functional keys? I think that's where the most benefit lies.

I think that could be fine.
Any comments @BlackyHawky?

[BlackyHawky]

I will test this PR after I finish my job. 😉

[BlackyHawky]

@Helium314 @eranl
First of all, thank you for asking my opinion.

After testing this PR, I find that the presence of the 3 dots overloads the display of the keys.
We see the 3 dots everywhere and it's visually too much!

By the way, adding the 3 dots on the Shift key is really weird; you would expect to see a popup appear like all the other keys while it activates permanent caps mode… Who doesn't already know this?
Also, why doesn't the Delete key have the 3 dots when a long press on it activates a functionality?

Once again, I'm not in favor of visual changes when they're not requested by users, even if I understand EranL's point of view on the fact that nothing indicates to the user that a long press is possible on certain keys.
But that's how it is; Google has established their culture in using a keyboard for so many years (followed later by Samsung, etc.), that this kind of change is "useless".
And, we must not forget that the majority of users have not used Heliboard as their first keyboard and therefore are already aware that long presses are possible on the keys affected by this PR.

To conclude, if you really want this change to be validated, I think you should replace the SwitchPreference with a DialogPreference where the keys and views concerned would be listed:

• Numerical row
• Keyboard keys
• Shift key
• Delete key
• Functional keys (comma, full stop)
• Space bar
• Enter key
• Symbols key
• More symbols keys
• Numpad keys

The user would then be free to choose which keys he wants to remember that a long press is possible.

[eranl]

has popup hint should also be removed from attrs.xml then

Done.

potentially from built-in layouts if any use the code.

I didn't find any.

Should I continue to support this for custom layouts only?

Would it be more acceptable if I limited this change to functional keys? I think that's where the most benefit lies.

I think that could be fine.

Done.

After testing this PR, I find that the presence of the 3 dots overloads the display of the keys. We see the 3 dots everywhere and it's visually too much!

Reduced to just functional keys now.

By the way, adding the 3 dots on the Shift key is really weird;

Agreed. Removed.

Please give this another try now and let me know what you think. Thanks.

[BlackyHawky]

@eranl

Reduced to just functional keys now.
Please give this another try now and let me know what you think. Thanks.

I think this is the best choice. It's much better! 👍

Thank you for taking my opinion into account (even if I don't hold the absolute truth 😅)