-
-
Notifications
You must be signed in to change notification settings - Fork 193
Improve toolbar switch button usability #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ons. Make toolbar switch button larger. Highlight suggestions button when suggestions are available.
|
I would like to have a very consistent / stable style for the keyboard itself (both visual and behavior), so people do not have to get used to changes after upgrades. Exceptions are mostly when it's a clear improvement, or concerning minor details. Other things should be optional. With the button change, I think the size is a clear drawback as the tool / suggestion bar is already easily too full. With the icons I'm not sure... I'm not fully opposed, but I don't see a good enough reason to change. |
Would any of these changes work as setting-controlled options?
How about just eliminating this shrinking? |
In my opinion it looks weird with the small icon. But increasing size of the icon instead of decreasing size of the button should take care of this.
For the highlighting it would work. |
But that wouldn't help with hitting the button. Can I enlarge both the icon and the button?
I couldn't find anything else that would work in all color schemes. This one seems to be the only color meant to be used on the toolbar. Would the gradient-ed version of it used for pinned keys work? |
To me as a new user, this button seemed very confusing. It was hard for me to tell what it did. The right and left directions it points to didn't help. That's why I think more topical icons would be better. |
I don't understand, why did you suggest removing the shrinking then? Or is there some side effect in increasing the icon size I didn't consider?
If you enlarge the button it will be too tall for the toolbar in landscape mode. Even in portrait mode you could enlarge it by only ~5% |
Please correct me if I'm wrong - my understanding is that it's shrinking the button, thus making it harder to hit. |
|
I think we might be talking about somewhat different things, or understand things differently. I hope this helps clarifying: |
|
Got it. So can I remove the shrinking and enlarge the icon? |
|
Yes, I think it should be fine. |
Done. |
Have you seen this question? Also, what's your final word about changing the icons? |
This is a conceptual prototype, limited by my lack of graphic design skills. Happy to ship any part of this separately if desired.
Changes:
Fixes #1412.