fix(a11y): add aria-label to AmountInput field (#467) - #570
Merged
dadadave80 merged 1 commit intoSep 5, 2026
Merged
Conversation
…pair build/test suite - Add accessible aria-label attribute to AmountInput field, defaulting to 'Investment amount' or using provided label prop (Heliobond#467) - Add accessibility regression tests in AmountInput.test.tsx verifying screen reader role and label detection - Fix upstream merge syntax and type errors in Deposit.tsx, ProjectDetail.tsx, OracleForms.tsx, api.ts, kycValidation.ts, data.ts, projectDetails.ts, vault.ts, useVault.ts - Extract client-safe i18n configuration to src/i18n/config.ts preventing server next/headers leaks into client components - Remove missing CSS file imports in styles/index.css - Ensure 100% green pass on vitest (359 tests), tsc --noEmit, and next build
|
@Simultech369 is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
sshdopey
approved these changes
Sep 5, 2026
sshdopey
left a comment
sshdopey
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this thoughtful PR! Adding the aria-label to AmountInput directly addresses the accessibility issue, and the accompanying tests are a great touch. I also appreciate the extra care you took to fix build and type issues along the way, and the i18n refactor looks clean. The changes are well-tested and the build is green. Nice work! ❤️
Contributor
|
Approved! 🎉 I couldn't auto-merge this just yet (it may need a rebase or have a check still running). A maintainer can merge it whenever it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467
Summary of Changes
AmountInput.tsx): Addedaria-label={label || 'Investment amount'}to the numeric input element so screen readers can properly identify and announce the input's purpose to users.AmountInput.test.tsx): Added accessibility unit tests verifying screen reader label detection for both default and custom label scenarios.Deposit.tsx,ProjectDetail.tsx,OracleForms.tsx,api.ts,kycValidation.ts,data.ts,projectDetails.ts,vault.ts, anduseVault.ts.src/i18n/config.tsto prevent server-sidenext/headersleaks into client components during Turbopack production builds.bun run typecheck: 0 errorsbun run test: 45 test files passed (359 tests green)bun run build: Next.js production build succeeds with Turbopack