Skip to content

fix: reject deletion of non-archived projects (Closes #325) #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurentketterle-hub wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reject deletion of non-archived projects (Closes #325) #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions project_registry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,17 @@ impl ProjectRegistry {
pub fn delete_project(env: Env, project_id: u32) {
require_current_state(&env);
// Verify project exists
let _project: ProjectData = env
let project: ProjectData = env
.storage()
.persistent()
.get(&DataKey::Project(project_id))
.unwrap_or_else(|| panic_with_error!(&env, RegistryError::ProjectNotFound));

// NOTE: In production, should verify no investments via vault.get_project_investment(project_id)
// For now, we allow deletion assuming caller has verified no active investments
// Reject deletion of non-archived projects (#325): a project that is still
// Active/Funded/Pending may carry active investments.
if project.status != types::ProjectStatus::Archived {
panic_with_error!(&env, RegistryError::ProjectNotArchived);
}

env.storage()
.persistent()
Expand Down
Loading