Popup: make the long-press selection highlight clearly visible (#2440) - #2689
Open
MiMoHo wants to merge 2 commits into
Open
Popup: make the long-press selection highlight clearly visible (#2440)#2689MiMoHo wants to merge 2 commits into
MiMoHo wants to merge 2 commits into
Conversation
The long-press popup's selected key was highlighted with the full accent (system_accent1_100), which is glaringly light on the dark keyboard. Use the darkened accent (doubleAdjustedAccent) for the Holo popup highlight in dark mode, matching how the Material night popup already uses a darkened accent, so the selection is still clearly marked but not blindingly bright. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The popup selection highlight in the static themes used doubleAdjustedBackground, a barely-visible background shade. Use the theme accent instead, so the popup key highlighting is clearly noticeable (HeliBorg#2440) and consistent with the dynamic theme. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the popup key highlighting part of #2440.
The long-press popup's selected key was hard to make out in dark mode:
system_accent1_100), which is glaringly light on the dark keyboard.doubleAdjustedBackground, a barely-visible background shade.This makes the selection a clear, consistent accent marker:
DynamicColors(Holo, dark): dim the accent (doubleAdjustedAccent) — noticeable but not blinding.Dynamic, dark
Static "dark" theme
Highlight luminance in dark mode: dynamic 203 → 186, static "dark" 76 → 181. Only the popup selection state changes; each theme now marks the selection with its own accent.