Skip to content

fix(windows): improve Codex app discovery and CDP startup - #5

Open
liming2020 wants to merge 2 commits into
HeiGeAi:mainfrom
liming2020:codex/improve-codex-app-discovery
Open

fix(windows): improve Codex app discovery and CDP startup#5
liming2020 wants to merge 2 commits into
HeiGeAi:mainfrom
liming2020:codex/improve-codex-app-discovery

Conversation

@liming2020

Copy link
Copy Markdown

Summary / 概要

Improve Windows Codex app discovery and CDP startup diagnostics.
改进 Windows Codex 应用发现逻辑和 CDP 启动诊断。

Problem / 问题

Codex++ manager executables could be incorrectly selected as the Codex client, causing CDP startup and injection to fail.

程序可能会误将 Codex++ 管理器识别为 Codex 客户端,导致 CDP 启动和注入失败。

Scenarios Addressed / 主要解决场景

  • Microsoft Store version is installed without a traditional installation directory.

    • Microsoft Store 版本没有常规安装目录,导致传统路径探测失败。
  • Codex++ manager is detected from registry entries or Start Menu shortcuts.

    • 从注册表或开始菜单快捷方式中误检测到 Codex++ 管理器。
  • The manager does not forward Chromium remote-debugging parameters.

    • 管理器不会转发 Chromium 远程调试参数,导致 CDP 无法启动。
  • A running Codex process uses a WindowsApps path that cannot be launched directly.

    • 正在运行的 Codex 进程位于 WindowsApps 目录,不能直接使用进程路径重新启动。
  • Custom installation paths or the HEIGE_CODEX_APP environment variable are used.

    • 用户使用自定义安装路径或 HEIGE_CODEX_APP 环境变量指定客户端。

Changes / 修改内容

  • Prefer Microsoft Store package activation for Store-installed Codex.

    • Microsoft Store 安装优先通过应用包身份启动。
  • Only accept ChatGPT.exe or Codex.exe as valid client executables.

    • 仅接受 ChatGPT.exeCodex.exe 作为有效客户端。
  • Skip manager, installer, updater, and unrelated shortcut targets.

    • 跳过管理器、安装程序、更新程序及无关快捷方式目标。
  • Preserve support for custom paths and traditional installations.

    • 保留自定义路径和传统安装方式的兼容性。
  • Add detailed diagnostics for app discovery, launch targets, startup methods, and CDP readiness.

    • 增加应用查找、启动目标、启动方式和 CDP 就绪状态的详细诊断日志。

Testing / 测试

  • Verified that the branch can be merged automatically.

    • 已确认分支可以自动合并。
  • Verified the updated commit history and remote branch.

    • 已确认提交记录和远程分支已更新。
  • No automated test suite is available for the Windows launcher script.

    • 当前没有针对 Windows 启动脚本的自动化测试。

Checklist / 检查清单

  • Changes are limited to Windows launcher logic.

  • 修改范围仅限于 Windows 启动逻辑。

  • Existing installation methods remain supported.

  • 保留现有安装方式的支持。

  • Microsoft Store installation is handled correctly.

  • 正确处理 Microsoft Store 安装方式。

  • Codex++ manager executables are excluded.

  • 排除 Codex++ 管理器程序。

  • Diagnostic logging has been added.

  • 已增加诊断日志。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant