fix(windows): improve Codex app discovery and CDP startup - #5
Open
liming2020 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概要
Improve Windows Codex app discovery and CDP startup diagnostics.
改进 Windows Codex 应用发现逻辑和 CDP 启动诊断。
Problem / 问题
Codex++ manager executables could be incorrectly selected as the Codex client, causing CDP startup and injection to fail.
程序可能会误将 Codex++ 管理器识别为 Codex 客户端,导致 CDP 启动和注入失败。
Scenarios Addressed / 主要解决场景
Microsoft Store version is installed without a traditional installation directory.
Codex++ manager is detected from registry entries or Start Menu shortcuts.
The manager does not forward Chromium remote-debugging parameters.
A running Codex process uses a WindowsApps path that cannot be launched directly.
Custom installation paths or the
HEIGE_CODEX_APPenvironment variable are used.HEIGE_CODEX_APP环境变量指定客户端。Changes / 修改内容
Prefer Microsoft Store package activation for Store-installed Codex.
Only accept
ChatGPT.exeorCodex.exeas valid client executables.ChatGPT.exe或Codex.exe作为有效客户端。Skip manager, installer, updater, and unrelated shortcut targets.
Preserve support for custom paths and traditional installations.
Add detailed diagnostics for app discovery, launch targets, startup methods, and CDP readiness.
Testing / 测试
Verified that the branch can be merged automatically.
Verified the updated commit history and remote branch.
No automated test suite is available for the Windows launcher script.
Checklist / 检查清单
Changes are limited to Windows launcher logic.
修改范围仅限于 Windows 启动逻辑。
Existing installation methods remain supported.
保留现有安装方式的支持。
Microsoft Store installation is handled correctly.
正确处理 Microsoft Store 安装方式。
Codex++ manager executables are excluded.
排除 Codex++ 管理器程序。
Diagnostic logging has been added.
已增加诊断日志。