fix Windows controller startup reliability - #23
Draft
xipfs wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
icaclsno longer receives a bare SID through/setowner, which fails with Windows error 1332.Root causes
Three related Windows races were observed on the Microsoft Store build:
Set-Aclcan fail in a limited session. The fallback passed a bare SID toicacls /setowner, which Windows interpreted as an account name and rejected with error 1332. This surfaced asLOCK_PERMISSIONS.160/160without an applied skin.controller:startbeyond the background ACK window and triggering compensation back to disabled.Impact
Windows Store users can apply a skin and enable persistent background control without the observed
LOCK_PERMISSIONS, repeated160/160confirmation failures, or background-confirmation timeout caused by unnecessary ACL churn.Validation
EPERM).persistenceEnabled: true, revision 6; transition journal cleared; scheduled task remainedRunning; exactly one background controller remained after handoff.git diff --checkpassed.