refactor: remove old apply_date_shifts - #140
Open
g-pechorin wants to merge 6 commits into
Open
g-pechorin wants to merge 6 commits into
g-pechorin wants to merge 6 commits into
Conversation
shift_inline is now passing all of the tests
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
g-pechorin
marked this pull request as ready for review
September 18, 2026 09:45
g-pechorin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Removes the old date shifting functions, retargets unit tests from those to run the new _inplace variant, and, fixes an issue that uncovered.
Related Issues or other material
Related #
Closes #
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
[optional] What gif best describes this PR or how it makes you feel?