Skip to content

fix: supports blank columns - #138

Merged
g-pechorin merged 5 commits into
mainfrom
bug.blank-cols
Sep 16, 2026
Merged

g-pechorin merged 5 commits into
mainfrom
bug.blank-cols

Conversation

@g-pechorin

@g-pechorin g-pechorin commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
🦋 Bug Fix

PR Description

Adds tests for blank columns and for checking that blanks don't have data elsewere.

Passes the tests

Related Issues or other material

Related #116
Closes #137

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

  • This PR contains relevant tests / Or doesn't need to per the below explanation

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@g-pechorin
g-pechorin marked this pull request as ready for review September 15, 2026 16:15
@g-pechorin
g-pechorin requested a review from AndyRae as a code owner September 15, 2026 16:15
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissBranchBrPartCoverMissing
nuh_helper/date_shift
   __init__.py278181061689%149->158, 167, 255->253, 257->251, 376->390, 400->415, 402, 552, 578, 601, 614, 622–629, 665, 687, 691, 697
   _excel.py942256771%27->26, 34, 124–137, 174, 207->213, 220–231
   _parse.py30516285%31–40
nuh_helper/profile
   __init__.py178254298%180->183, 255–256
TOTAL600472362789% 

Tests Skipped Failures Errors Time
93 0 💤 0 ❌ 0 🔥 12.471s ⏱️

@g-pechorin
g-pechorin marked this pull request as draft September 16, 2026 09:10
@g-pechorin
g-pechorin marked this pull request as ready for review September 16, 2026 09:10
@g-pechorin
g-pechorin merged commit 5771164 into main Sep 16, 2026
9 checks passed
@g-pechorin
g-pechorin deleted the bug.blank-cols branch September 16, 2026 09:40
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.7.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structural checks can't tolerate blank columns

3 participants