feat: date sanity - #131
Open
g-pechorin wants to merge 8 commits into
Open
g-pechorin wants to merge 8 commits into
g-pechorin wants to merge 8 commits into
Conversation
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
AndyRae
reviewed
Sep 1, 2026
| seed: Optional random seed for generating shifts. | ||
| patient_header_row: Zero-based header row index for the patient sheet (default: 0). | ||
| patient_skip_rows: Optional zero-based row indices to exclude from patient data. | ||
| sanity_date_latest, sanity_date_earliest: latest and earliest dates allowed in the data. used as a sanity check |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
g-pechorin
marked this pull request as draft
September 4, 2026 12:37
g-pechorin
marked this pull request as ready for review
September 16, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Tests and checks to be sure dates aren't outside of a sensible range.
... so when people type 19/12/1008 instead of 19/11/2008 we can catch it ...
Related Issues or other material
Related #
Closes #117
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
[optional] What gif best describes this PR or how it makes you feel?