Skip to content

feat: date detection - #130

Merged
g-pechorin merged 11 commits into
mainfrom
feat.date-detect
Sep 14, 2026
Merged

g-pechorin merged 11 commits into
mainfrom
feat.date-detect

Conversation

@g-pechorin

Copy link
Copy Markdown
Contributor
✨ Feature

PR Description

Detects dates in places that they shouldn't be and halts shifting

Related Issues or other material

Related #
Closes #8

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

  • This PR contains relevant tests / Or doesn't need to per the below explanation

It specifically detects dates like this ...

  • hives on 2023-10-12
  • can't recall the date but on 12/11/2001 they had an itchy tummy
  • flu on mar 21st, 2009

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@g-pechorin
g-pechorin requested a review from AndyRae as a code owner September 1, 2026 14:25
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissBranchBrPartCoverMissing
nuh_helper/date_shift
   __init__.py20520881884%80->89, 98, 186->184, 188->182, 307->321, 331->346, 333, 448–449, 459, 467->466, 471, 481, 488, 496–503, 539, 561, 565, 571
   _excel.py942356870%27->26, 34, 93, 124–137, 174, 207->213, 220–231
   _parse.py30516285%31–40
nuh_helper/profile
   __init__.py171254298%180->183, 248–249
TOTAL520502183086% 

Tests Skipped Failures Errors Time
85 0 💤 0 ❌ 0 🔥 8.241s ⏱️

AndyRae
AndyRae previously approved these changes Sep 1, 2026

@AndyRae AndyRae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Comment thread nuh_helper/date_shift/__init__.py Fixed
@g-pechorin

Copy link
Copy Markdown
Contributor Author

I also added some comments to sort of "anchor" the other PRs and avoid/reduce merge conflicts

AndyRae
AndyRae previously approved these changes Sep 7, 2026
@g-pechorin
g-pechorin merged commit 56e44b0 into main Sep 14, 2026
9 checks passed
@g-pechorin
g-pechorin deleted the feat.date-detect branch September 14, 2026 09:33
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date detection (unshifted)

3 participants