Skip to content

feat: if there's no patient id - the row needs to be blank - #127

Open
g-pechorin wants to merge 10 commits into
mainfrom
feat.blanks
Open

g-pechorin wants to merge 10 commits into
mainfrom
feat.blanks

Conversation

@g-pechorin

@g-pechorin g-pechorin commented Aug 26, 2026

Copy link
Copy Markdown
Contributor
✨ Feature
🦋 Bug Fix

PR Description

Safety check to prevent loose data that's not shifted.
Does one half of #78 by raising an error when the source data has rows with no patient id, but, does have some data.

Related Issues or other material

Related #78
Closes #

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

  • This PR contains relevant tests / Or doesn't need to per the below explanation

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissBranchBrPartCoverMissing
nuh_helper/date_shift
   __init__.py300181101690%169->178, 187, 275->273, 277->271, 396->410, 420->435, 422, 572, 598, 621, 634, 642–649, 700, 722, 726, 732
   _excel.py942256771%27->26, 34, 124–137, 174, 207->213, 220–231
   _parse.py30516285%31–40
nuh_helper/profile
   __init__.py178254298%180->183, 255–256
TOTAL622472402789% 

Tests Skipped Failures Errors Time
95 0 💤 0 ❌ 0 🔥 6.491s ⏱️

@g-pechorin
g-pechorin marked this pull request as ready for review August 27, 2026 11:06
@g-pechorin
g-pechorin requested a review from AndyRae as a code owner August 27, 2026 11:06
@g-pechorin g-pechorin changed the title feat: enforces blank rows when there's no patient id feat: no patient id - don't allow data Sep 14, 2026
@g-pechorin
g-pechorin marked this pull request as draft September 14, 2026 11:50
@g-pechorin g-pechorin changed the title feat: no patient id - don't allow data feat: if there's no patient id - the row needs to be blank Sep 14, 2026
@g-pechorin
g-pechorin marked this pull request as ready for review September 14, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants