Add arm #37
Open
Add arm #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GM-Alex
force-pushed
the
feature/add-arm
branch
from
ae9a840 to
2c6ad1e
Compare
Contributor
|
can we get this merged please |
tobil4sk
reviewed
Dec 17, 2025
|
|
||
| var url = plateform === 'arm64' | ||
| ? "https://build.haxe.org/builds/neko/linux-arm64/neko_latest.tar.gz" | ||
| : "https://github.com/HaxeFoundation/neko/releases/download/v"+version+"/neko-"+this.nekoVersion+"-"+plateform; |
Member
There was a problem hiding this comment.
Neko versions 2.4.0 and above have an linux arm build provided: linux-arm64.tar.gz, so that should be used instead of hard coding the nightly build.
Mac is still hardcoded to install the x86 version, it should also use osx-arm64.tar.gz for arm.
Ideally we would have version checks to give an error if neko is too old to support arm64, but we don't seem to have a semver dependency yet. For now maybe we can add an alternative error message if the download fails on an arm machine to suggest that the user might have to update the neko version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add download options for arm like Apple silicon.