v2: final version before any other major feature is needed rest is just optional#3
Open
AbhinavGupta-de wants to merge 5 commits intomainfrom
Open
v2: final version before any other major feature is needed rest is just optional#3AbhinavGupta-de wants to merge 5 commits intomainfrom
AbhinavGupta-de wants to merge 5 commits intomainfrom
Conversation
…ato Club - Updated project title to "Hot Potato Club". - Added a description of the game and its rules. - Removed outdated setup instructions and replaced them with gameplay steps.
- Introduced `setRoundLoser` function in GameContext to handle the selection of the player who lost the round. - Updated gameReducer to manage the state change when a round loser is set, incrementing the `roundsLost` for the selected player. - Created a new `SelectLoser` screen for players to choose who was holding the bomb when it exploded. - Modified gameplay logic to navigate to the new selection screen after an explosion. - Removed unused assets and cleaned up the gameplay screen for better clarity and functionality.
- Changed app icon path in app.json to use a new logo. - Added a splash screen configuration in app.json. - Updated package dependencies: fixed version for @react-native-community/slider, added expo-mail-composer, and upgraded react-native-screens. - Enhanced Home screen with a new feedback button that navigates to a feedback screen. - Implemented a new Feedback screen allowing users to submit feedback via email, including validation and error handling. - Added styling for new buttons and feedback form elements.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several new features and improvements for the Hot Potato Club game, including dependency updates, new game screens (select-loser and feedback), and enhancements to gameplay and home screen interactions.
- Updated dependencies and minor version bumps in package.json
- Added new screens for selecting a round loser and collecting user feedback
- Adjusted user interface elements and messaging for gameplay and home screens
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added new dependencies and updated versions to support new features |
| app/screens/setup-players.tsx | Removed some validation checks; now creates player objects with details |
| app/screens/select-loser.tsx | Introduces a new screen for selecting the round loser |
| app/screens/gameplay.tsx | Adjusted explosion alert and UI messaging; removed unused functions |
| app/screens/feedback.tsx | New screen to allow users to submit feedback via email |
| app/home.tsx | Added feedback and donate buttons with improved navigation/linking |
| app/_types/GameTypes.ts | Updated types to interfaces and added additional properties to Player |
| app/_context/gameReducer.ts | Added a new action to record the round loser and update player stats |
| app/_context/GameContext.tsx | Exposed setRoundLoser to update game state |
| app.json | Updated app icon and splash screen assets |
| README.md | Updated documentation to reflect the current game instructions |
Comments suppressed due to low confidence (2)
app/screens/select-loser.tsx:76
- [nitpick] Consider using a unique identifier (e.g., player.id) as the key instead of the array index for the player list to improve rendering stability.
<TouchableOpacity key={index} style={[
app/home.tsx:25
- Update the fallback donation URL message so it matches the actual donation URL ('https://www.hawkslab.online/donate') to avoid user confusion.
Alert.alert('Unable to Open', 'Sorry, we couldn\'t open the donation page. Please visit your-donation-website.com directly in your browser.');
- Changed the donation page URL in alert messages to the correct link: https://www.hawkslab.online/donate. - Ensured users receive accurate information when unable to open the donation page or when an error occurs.
- Updated StatusBar style from "auto" to "dark" in multiple screens for consistent appearance. - Added StatusBar component in the RootLayout for improved app visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.