Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PropertyNameCaseInsensitive setting #42

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

twenzel
Copy link
Contributor

@twenzel twenzel commented Jan 16, 2025

Fixes #41

@Havunen
Copy link
Owner

Havunen commented Jan 16, 2025

Some test cases seems to be failing, did you check if those other adapters needs case sensitive checking / fixes?

@twenzel
Copy link
Contributor Author

twenzel commented Jan 16, 2025

@Havunen fixed.
At the moment I see no other adapter seeing this missing.

@twenzel
Copy link
Contributor Author

twenzel commented Jan 16, 2025

@Havunen Found another adapter. Fixed it.

Copy link
Owner

@Havunen Havunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Havunen
Copy link
Owner

Havunen commented Jan 16, 2025

Thank you for your contribution to this project!

@Havunen Havunen merged commit b7cf008 into Havunen:main Jan 16, 2025
3 checks passed
@twenzel
Copy link
Contributor Author

twenzel commented Jan 16, 2025

@Havunen Is is possible to publish a new release with this change?

@twenzel twenzel deleted the feature/HandlePropertyCasing branch January 17, 2025 06:07
@Havunen
Copy link
Owner

Havunen commented Jan 17, 2025

This change is now available in version 4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonPatchDocument ignores PropertyNameCaseInsensitive setting
2 participants