Skip to content

Conversation

Copy link

Copilot AI commented Dec 11, 2025

FlushOptions and WriteOptions were instantiated and configured in RocksDbContext but never passed to RocksDB operations, causing settings like DisableWal and WaitForFlush to be ignored.

Changes

  • RocksDbContext: Store FlushOptions and WriteOptions as fields and expose via properties
  • RocksDbAccessor: Pass WriteOptions to Put(), Remove(), and Write() operations
  • Tests: Add WriteOptionsTests to verify options are applied to write operations

Before

var writeOptions = new WriteOptions();
writeOptions.DisableWal(1);
// Created but never used

_rocksDbContext.Db.Put(keySpan, valueSpan, _columnFamily.Handle);

After

_writeOptions = new WriteOptions();
_writeOptions.DisableWal(1);

_rocksDbContext.Db.Put(keySpan, valueSpan, _columnFamily.Handle, _rocksDbContext.WriteOptions);
Original prompt

On RocksDbContext.cs, It seems that these values are not used:

 var fOptions = new FlushOptions();
    fOptions.SetWaitForFlush(options.Value.WaitForFlush);

    var writeOptions = new WriteOptions();
    writeOptions.DisableWal(1);

create an issue to fix this and actually use them


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix unused FlushOptions and WriteOptions in RocksDbContext Use configured FlushOptions and WriteOptions in RocksDbContext Dec 11, 2025
Copilot AI requested a review from Havret December 11, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants