Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NanoContractTransaction screen [12] #440

Merged
merged 15 commits into from
Jun 14, 2024
Merged

feat: add NanoContractTransaction screen [12] #440

merged 15 commits into from
Jun 14, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Mar 12, 2024 •
edited
Loading

Acceptance Criteria

  • It should add NanoContractTransaction screen

  • It should add a NanoContractTransactionHeader component

  • It should improve FeedbackContent component by adding a wrapper layer with overflow scroll

  • It should add icon Received.icon component

  • It should add icon Sent.icon component

  • It should improve TextValue by adding title option

  • It should add NanoContractTransactionActionList component

  • It should add NanoContractTransactionActionListItem component

Warning

The action components are not being used because it requires new methods at wallet-lib that are not yet implemented.

Warning

I already changed the screen title, despite the recording and screenshots is steel showing the old title.

Nano Contract Transaction Screen showing a bet transaction

nc-transaction-recording.mp4

Nano Contract Transaction header expaned

Note

It depends on:

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Mar 12, 2024
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transactions-component branch 2 times, most recently from 1e13c7d to 593332c Compare April 1, 2024 16:02
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch 2 times, most recently from 6a6e1e7 to a0caced Compare April 1, 2024 18:16
@alexruzenhack alexruzenhack changed the title feat: add NanoContractTransaction screen feat: add NanoContractTransaction screen [12] Apr 8, 2024
This was referenced Apr 9, 2024
Open
Merged
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transactions-component branch from 593332c to d0fd277 Compare May 14, 2024 15:16
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from a0caced to f823c2b Compare May 14, 2024 15:25
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transactions-component branch 8 times, most recently from 30f3fe4 to 82141bb Compare May 29, 2024 23:34
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch 3 times, most recently from a946e8f to 12d5cc2 Compare June 1, 2024 00:41
andreabadesso
andreabadesso requested changes Jun 4, 2024
View reviewed changes
src/components/NanoContract/NanoContractTransactionBalanceList.component.js Outdated
const isHeightLocked = this.isHeightLocked(tx.height, nowHeight, rewardLock);

for (const output of tx.outputs) {
// Removed isAddressMine filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this comment? Removed from where?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File removed.

src/components/NanoContract/NanoContractTransactionBalanceList.component.js Outdated
}

for (const input of tx.inputs) {
// Removed isAddressMine filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File removed.

src/components/NanoContract/NanoContractTransactionBalanceListItem.component.js Outdated
* @param {string} tokenUid Token hash
* @param {Object[]} tokens Registered tokens from redux store
*/
function getTokenValue(tokenUid, tokens) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to getTokenSymbol? Value is misleading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File removed.

@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from 85e37f7 to 43a9a85 Compare June 4, 2024 16:24
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transactions-component branch from 72a5b61 to 4da4f91 Compare June 4, 2024 22:47
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch 2 times, most recently from 33a6d7a to 34fffb2 Compare June 7, 2024 17:44
andreabadesso
andreabadesso requested changes Jun 12, 2024
View reviewed changes
locale/pt-br/texts.po Outdated

#: src/components/NanoContract/NanoContractTransactionBalanceListItem.component.js:109
msgid "Sent ${ tokenValue }"
msgstr "Enviado ${ symbol }"
Copy link
Contributor

@andreabadesso andreabadesso Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Variable names is different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

src/components/NanoContract/NanoContractTransactionActionList.component.js Outdated
useEffect(() => {
// TODO: implement fetchActions to get actions of a transaction
const fetchActions = async () => {
// TODO: getActions must be implemented in the lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And should also be a saga

Will this PR wait until the lib is updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. But I can rip off this component until we have the actions on each nano contract transaction.

src/components/NanoContract/NanoContractTransactionHeader.component.js Outdated
<PrimaryTextButton title={t`See transaction details`} onPress={navigatesToExplorer} />
</TwoActionsWrapper>
</View>
{/* TODO: add <ArrowUpIcon /> when action list is ready to be showed */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a TODO? Will this PR be merged or wait the getActions method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be merged. But I will rip off this reference to actions. I believe it will be better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Base automatically changed from feat/nano-contract-transactions-component to master June 12, 2024 21:23
@alexruzenhack
feat: add nano contract transaction screen
69dcc3f
@alexruzenhack
feat: add nano contract transaction components
91e42ac 
chore: rename NanoContractTransactionScreen.js

chore: some tweaks

lint: comply with rules

fix: small fixes
@alexruzenhack
feat: improve NanoContractTransaction* components
57532e8 
- Add FeedbackContent for no input/ouput on NanoContractTransactionBalanceList
- Minor fix on NanoContractTransactionHeader
@alexruzenhack
fix: navigation to NanoContractTransactionScreen
ee8d734
@alexruzenhack
chore: update i18n
13e39f0
@alexruzenhack
chore: remove legacy nano contract transactions component
fde20b2
@alexruzenhack
chore: undo comment
f8e5e62
@alexruzenhack
chore: remove balance list from transaction screen and minor tweaks
f283356
@alexruzenhack
rename balance list to action list
7c81658
@alexruzenhack
chore: rename methods
146e490
@alexruzenhack
chore: change no actions text
f554f5e
@alexruzenhack
chore: improve documentation on transaction actions component
3107526
@alexruzenhack
review: apply suggestions
07dc64b
@alexruzenhack
chore: remove actions list components
fb783ca
@alexruzenhack
chore: update transaction header component with action component comm…
a9caff1 
…ents
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-transaction-details-component branch from 34fffb2 to a9caff1 Compare June 13, 2024 13:10
@alexruzenhack alexruzenhack merged commit 99f4997 into master Jun 14, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the feat/nano-contract-transaction-details-component branch June 14, 2024 02:26
andreabadesso pushed a commit that referenced this pull request Jun 24, 2024
@alexruzenhack @andreabadesso
feat: add NanoContractTransaction screen [12] (#440)
a913c5a 
* feat: add nano contract transaction screen
* feat: add nano contract transaction components
* Add FeedbackContent for no input/output on NanoContractTransactionBalanceList
* fix: navigation to NanoContractTransactionScreen
@alexruzenhack alexruzenhack mentioned this pull request Aug 13, 2024
Closed
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
@tuliomir tuliomir mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso