Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nano contract list component [7] #435

Merged
merged 19 commits into from
May 24, 2024
Merged

feat: nano contract list component [7] #435

merged 19 commits into from
May 24, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Mar 1, 2024 •
edited
Loading

Motivation

This PR implements the Nano Contract List component for read-only purpose. The actions related to this component will be implemented in the sequence.

Acceptance Criteria

  • it should refactor the Dashboard screen to introduce TwoOptionsToggle component
  • it should refactor the Dashboard component to introduce Nano Contract feature toggle
  • it should implement Nano Contract List component and its sub components
  • it should replace FlatList to HathorFlatList from previous PRs
  • it should add Hathor copyrights in some files

List of registered Nano Contract

nano-contract-list.mp4

Empty list

Nano Contract disabled

Nano Contract enabled

Note

It depends on:

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Mar 1, 2024
@anafigueired
Copy link

anafigueired commented Mar 1, 2024 •
edited
Loading

Everything meets the Design accordingly.

The "Empty State" screen is not showed on the video, but will be added.

@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-history branch from 7235cb2 to 8d2950f Compare March 5, 2024 16:14
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-list-component branch from 6f8bdd3 to f090d9e Compare March 5, 2024 21:34
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-history branch 4 times, most recently from 5467f59 to 4aaa4c9 Compare March 30, 2024 18:41
@alexruzenhack alexruzenhack changed the base branch from feat/nano-contract-history to feat/nano-contract-tx-history March 31, 2024 21:09
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-list-component branch 2 times, most recently from a62289f to 243c126 Compare March 31, 2024 23:19
@alexruzenhack alexruzenhack mentioned this pull request Apr 1, 2024
Merged
1 task
@alexruzenhack alexruzenhack changed the title feat: nano contract list component feat: nano contract list component [7] Apr 8, 2024
@andreabadesso andreabadesso mentioned this pull request Apr 10, 2024
Merged
1 task
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-list-component branch from 243c126 to bf4e720 Compare April 12, 2024 14:57
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-tx-history branch from bf7b4db to e5599cd Compare April 23, 2024 16:18
Base automatically changed from feat/nano-contract-tx-history to master May 3, 2024 21:47
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-list-component branch 2 times, most recently from 4b4bf63 to 2dbc975 Compare May 7, 2024 22:04
@alexruzenhack alexruzenhack requested review from andreabadesso, tuliomir and r4mmer and removed request for tuliomir May 7, 2024 22:57
r4mmer
r4mmer approved these changes May 14, 2024
View reviewed changes
src/components/TwoOptionsToggle.js Show resolved Hide resolved
src/models.js Show resolved Hide resolved
pedroferreira1
pedroferreira1 reviewed May 16, 2024
View reviewed changes
src/constants.js Outdated Show resolved Hide resolved
src/components/SimpleButton.js Show resolved Hide resolved
src/components/NanoContract/NanoContractIcon.icon.js Show resolved Hide resolved
src/components/TwoOptionsToggle.js Show resolved Hide resolved
src/components/TwoOptionsToggle.js Outdated Show resolved Hide resolved
src/components/TwoOptionsToggle.js Outdated Show resolved Hide resolved
src/screens/Dashboard.js Outdated Show resolved Hide resolved
@alexruzenhack alexruzenhack requested a review from r4mmer May 23, 2024 12:49
@alexruzenhack
feat: add nano contract list component
fe8a142
@alexruzenhack
chore: remove moved components and remove .component sufix
a0528a9
@alexruzenhack
chore: rename NanoContractIcon component file
639367c
@alexruzenhack
chore: add license in files head
fa30b74
@alexruzenhack
chore: remove .component sufix
9ea56c8
@alexruzenhack
chore: normalize styles
2cf2ed2
@alexruzenhack
refactor: extract documentation URL to constants
5bf153d
@alexruzenhack
lint: comply with rules
2b322e7
@alexruzenhack
chore: update translation files
584bca7
@alexruzenhack
fix: translations
aba026c
@alexruzenhack
chore: add children property in docstring of SimpleButton
3f3badb
@alexruzenhack
feat: add nano contract feature toggle to dashboard
097cd38
@alexruzenhack
chore: remove nc read more actio
d38f7ef
@alexruzenhack
feat: call onTap only when options are divergent
881e547
@alexruzenhack
chore: update translation files
fcc16b9
@alexruzenhack
refactor: TwoOptionsToggle component to simplify its mechanics
2e45467
@alexruzenhack
chore: update docstring of Option component
fe0b328
@alexruzenhack
review: apply fix suggestions
65b0c55
@alexruzenhack alexruzenhack force-pushed the feat/nano-contract-list-component branch from 090211f to 65b0c55 Compare May 23, 2024 16:20
andreabadesso
andreabadesso requested changes May 24, 2024
View reviewed changes
locale/pt-br/texts.po Outdated
Comment on lines 1268 to 1276
#~ msgid "Learn More."
#~ msgstr "Saiba mais"

#~ msgid "TOKENS"
#~ msgstr "TOKENS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these?

locale/ru-ru/texts.po Outdated

#: src/components/NanoContract/RegisterNewNanoContractButton.js:22
msgid "Register new"
msgstr "Зарегистрировать токен"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on this in another PR, but just so we don't lose this, this apparently translates to:

Register a token

Is this the correct translation?

locale/ru-ru/texts.po Outdated
Comment on lines 1221 to 1226
#~ msgid "TOKENS"
#~ msgstr "ТОКЕНЫ"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@alexruzenhack alexruzenhack merged commit 0dbdd37 into master May 24, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the feat/nano-contract-list-component branch May 24, 2024 13:34
andreabadesso pushed a commit that referenced this pull request Jun 24, 2024
@alexruzenhack @andreabadesso
feat: nano contract list component [7] (#435)
a59de91 
* feat: add nano contract list component
* feat: add nano contract feature toggle to dashboard
* refactor: TwoOptionsToggle component to simplify its mechanics
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
@tuliomir tuliomir mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

@r4mmer r4mmer r4mmer approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexruzenhack @anafigueired @pedroferreira1 @andreabadesso @r4mmer