Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: promise leak #772

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix: promise leak #772

merged 2 commits into from
Sep 16, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Sep 13, 2024

Acceptance Criteria

  • Fix promise leak in call of getTokenDetails

Note

We have had a similar problem before, see #584.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack requested review from tuliomir and andreabadesso and removed request for pedroferreira1 September 13, 2024 19:17
@alexruzenhack alexruzenhack self-assigned this Sep 13, 2024
@alexruzenhack alexruzenhack requested review from r4mmer and removed request for tuliomir September 13, 2024 19:17
@alexruzenhack alexruzenhack requested review from tuliomir and removed request for andreabadesso September 13, 2024 19:20
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.43%. Comparing base (420d258) to head (c2522be).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   80.45%   80.43%   -0.02%     
==========================================
  Files          79       79              
  Lines        6333     6333              
  Branches     1379     1370       -9     
==========================================
- Hits         5095     5094       -1     
- Misses       1226     1227       +1     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexruzenhack alexruzenhack merged commit fab4f26 into master Sep 16, 2024
4 checks passed
@alexruzenhack alexruzenhack deleted the fix/promise-leak branch September 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants